Add readonly iterators and support value mutations only from non-readonly iterators #345
Conversation
This change: - Adds ReadOnly iterators that match current iterator API (except for the "ReadOnly" suffix added to some function names). - Refactors API of non-Readonly iterators because register inlining will require more parameters for MapIterator. For ReadOnly iterators, the caller is responsible for preventing changes to child containers during iteration because mutations of child containers are not guaranteed to persist. For non-ReadOnly iterators, two additional parameters are needed to update child container in parent map when child container is modified.
fxamacker
added
enhancement
Is there are non-deterministic case there? |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## fxamacker/inline-array-and-map #345 +/- ##
==================================================================
+ Coverage 62.59% 62.62% +0.03%
==================================================================
Files 15 15
Lines 10492 10559 +67
==================================================================
+ Hits 6567 6613 +46
- Misses 2989 3004 +15
- Partials 936 942 +6
☔ View full report in Codecov by Sentry. |
Hi @bluesign, the readonly iterators will only be used internally in Cadence to reduce overhead. So "not guaranteed to persist" won't be a problem in this case. |
…omparator-and-hashinputprovider-to-mapiterator
This PR:
Changes:
For readonly iterators, the caller is responsible for preventing changes to child containers during iteration because mutations of child containers are not guaranteed to persist.
For non-readonly iterators, two additional parameters are needed to update child container in parent map when child container is modified.
mainbranchFiles changedin the Github PR explorer